[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210607091058.2766648-1-zhengyongjun3@huawei.com>
Date: Mon, 7 Jun 2021 17:10:58 +0800
From: Zheng Yongjun <zhengyongjun3@...wei.com>
To: <davem@...emloft.net>, <yoshfuji@...ux-ipv6.org>,
<dsahern@...nel.org>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: Zheng Yongjun <zhengyongjun3@...wei.com>
Subject: [PATCH] ping: Check return value of function 'ping_queue_rcv_skb'
Function 'ping_queue_rcv_skb' not always return success, which will
also return fail. If not check the wrong return value of it, lead to function
`ping_rcv` return success.
Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
---
net/ipv4/ping.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index 1c9f71a37258..8e84cde95011 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -968,10 +968,11 @@ bool ping_rcv(struct sk_buff *skb)
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
pr_debug("rcv on socket %p\n", sk);
- if (skb2)
- ping_queue_rcv_skb(sk, skb2);
+ if (skb2 && !ping_queue_rcv_skb(sk, skb2)) {
+ sock_put(sk);
+ return true;
+ }
sock_put(sk);
- return true;
}
pr_debug("no socket, dropping\n");
--
2.25.1
Powered by blists - more mailing lists