linux-kernel - Re: [PATCH -next] reset: mchp: sparx5: fix return value check in mchp_sparx5_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d222e3a93d192722099994441283193d6ed26a79.camel@pengutronix.de>
Date:   Mon, 07 Jun 2021 11:23:28 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        UNGLinuxDriver@...rochip.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] reset: mchp: sparx5: fix return value check in
 mchp_sparx5_map_io()

On Wed, 2021-05-19 at 14:16 +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_get_and_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
> 
> Fixes: 453ed4283beb ("reset: mchp: sparx5: add switch reset driver")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Thank you, applied to reset/fixes.

regards
Philipp