linux-kernel - Re: [PATCH] reset: berlin: support module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 07 Jun 2021 11:23:57 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: berlin: support module build

On Thu, 2021-05-20 at 17:13 +0800, Jisheng Zhang wrote:
> Make reset-berlin driver to be tristate module, support to build as
> a module, this is useful for GKI.
> 
> Partially revert commit ed4dba99cae8 ("reset: berlin: make it
> explicitly non-modular")
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
>  drivers/reset/Kconfig        |  4 ++--
>  drivers/reset/reset-berlin.c | 10 ++++++++--
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 3e7f55e44d84..1e7443a4dae1 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -43,8 +43,8 @@ config RESET_BCM6345
>  	  This enables the reset controller driver for BCM6345 SoCs.
>  
>  config RESET_BERLIN
> -	bool "Berlin Reset Driver" if COMPILE_TEST
> -	default ARCH_BERLIN
> +	tristate "Berlin Reset Driver"
> +	depends on ARCH_BERLIN || COMPILE_TEST

Is there a reason not to keep "default ARCH_BERLIN"?

regards
Philipp