linux-kernel - Re: [PATCH v1 3/3] usb: typec: intel_pmc_mux: Put ACPI device using acpi_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 12:26:07 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] usb: typec: intel_pmc_mux: Put ACPI device using
 acpi_dev_put()

On Sun, Jun 06, 2021 at 11:09:11PM +0300, Andy Shevchenko wrote:
> For ACPI devices we have a symmetric API to put them, so use it in the driver.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux/intel_pmc_mux.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index de40276cc18b..2d0a863956c7 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -582,12 +582,12 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc)
>  	acpi_dev_free_resource_list(&resource_list);
>  
>  	if (!pmc->iom_base) {
> -		put_device(&adev->dev);
> +		acpi_dev_put(adev);
>  		return -ENOMEM;
>  	}
>  
>  	if (IS_ERR(pmc->iom_base)) {
> -		put_device(&adev->dev);
> +		acpi_dev_put(adev);
>  		return PTR_ERR(pmc->iom_base);
>  	}
>  
> @@ -657,7 +657,7 @@ static int pmc_usb_probe(struct platform_device *pdev)
>  		usb_role_switch_unregister(pmc->port[i].usb_sw);
>  	}
>  
> -	put_device(&pmc->iom_adev->dev);
> +	acpi_dev_put(pmc->iom_adev);
>  
>  	return ret;
>  }
> @@ -673,7 +673,7 @@ static int pmc_usb_remove(struct platform_device *pdev)
>  		usb_role_switch_unregister(pmc->port[i].usb_sw);
>  	}
>  
> -	put_device(&pmc->iom_adev->dev);
> +	acpi_dev_put(pmc->iom_adev);
>  
>  	return 0;
>  }
> -- 
> 2.31.1

-- 
heikki