linux-kernel - Re: [PATCH v2] kprobes: remove duplicated strong free_insn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 12:57:53 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     akpm@...ux-foundation.org, hpa@...or.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, gor@...ux.ibm.com,
        borntraeger@...ibm.com, naveen.n.rao@...ux.ibm.com,
        anil.s.keshavamurthy@...el.com, davem@...emloft.net,
        mhiramat@...nel.org, linux-s390@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2] kprobes: remove duplicated strong free_insn_page in
 x86 and s390

On Mon, Jun 07, 2021 at 09:18:54PM +1200, Barry Song wrote:
> free_insn_page() in x86 and s390 are same with the common weak function
> in kernel/kprobes.c.
> Plus, the comment "Recover page to RW mode before releasing it" in x86
> seems insensible to be there since resetting mapping is done by common
> code in vfree() of module_memfree().
> So drop these two duplicated strong functions and related comment, then
> mark the common one in kernel/kprobes.c strong.
> 
> Cc: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
>  -v2:
>  remove free_insn_page in s390 as well and remove the __weak in common
>  code according to Christoph's comment;
> 
>  arch/s390/kernel/kprobes.c     | 5 -----
>  arch/x86/kernel/kprobes/core.c | 6 ------
>  kernel/kprobes.c               | 2 +-
>  3 files changed, 1 insertion(+), 12 deletions(-)

For the s390 part:
Acked-by: Heiko Carstens <hca@...ux.ibm.com>