linux-kernel - Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jgH64Kbi12+tYbq384z5qEOKB68VELwtq28oiF1DjxkA@mail.gmail.com>
Date:   Mon, 7 Jun 2021 13:09:00 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Kyle Meyer <kyle.meyer@....com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur

On Mon, Jun 7, 2021 at 9:26 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 07-06-21, 09:13, Takashi Iwai wrote:
> > The missing key information is that it's a fix for the recent change
> > for 5.14, i.e.
> > Fixes: c1d6d2fd2f64 ("cpufreq: acpi-cpufreq: Skip initialization if cpufreq driver is present")
> >
> > The change made the module left even if it exits before registering
> > the cpufreq driver object.
>
> The original patch looks buggy to me, I was never able to review it :(
>
> I have replied on the original thread instead.

Well, thanks, but that confused me a bit.

Given the above, I'm going to drop the original patch.

Kyle, please reconsider this approach.