linux-kernel - Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d1b517f-797f-e87d-4edd-8474b16993ed@amd.com>
Date:   Mon, 7 Jun 2021 14:30:13 +0200
From:   Christian König <christian.koenig@....com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>,
        Jianmin Lv <lvjianmin@...ngson.cn>
Subject: Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in
 radeon_pci_shutdown()

Am 07.06.21 um 14:27 schrieb Tiezhu Yang:
> radeon_suspend_kms() puts the hw in the suspend state (all asics),
> it should always call radeon_suspend_kms() in radeon_pci_shutdown(),
> this is a normal cleanup process to avoid more operations on radeon,
> just remove #ifdef CONFIG_PPC64 and the related comments.

Well NAK.

Alex knows more about the details but suspending should not be part of 
the pci shotdown process at all.

We just add that here to enforce a GPU reset on PPC64 boards for some 
reason.

Regards,
Christian.

>
> Co-developed-by: Jianmin Lv <lvjianmin@...ngson.cn>
> Signed-off-by: Jianmin Lv <lvjianmin@...ngson.cn>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>   drivers/gpu/drm/radeon/radeon_drv.c | 9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index efeb115..0b1f43d 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -386,16 +386,7 @@ radeon_pci_shutdown(struct pci_dev *pdev)
>   	if (radeon_device_is_virtual())
>   		radeon_pci_remove(pdev);
>   
> -#ifdef CONFIG_PPC64
> -	/*
> -	 * Some adapters need to be suspended before a
> -	 * shutdown occurs in order to prevent an error
> -	 * during kexec.
> -	 * Make this power specific becauase it breaks
> -	 * some non-power boards.
> -	 */
>   	radeon_suspend_kms(pci_get_drvdata(pdev), true, true, false);
> -#endif
>   }
>   
>   static int radeon_pmops_suspend(struct device *dev)