lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jun 2021 18:00:48 +0530 From: Bhupesh Sharma <bhupesh.sharma@...aro.org> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: linux-arm-msm@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>, Andy Gross <agross@...nel.org>, devicetree <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, bhupesh.linux@...il.com Subject: Re: [PATCH 4/8] regulator: qcom-rpmh: Add new regulator types found on SA8155p adp board On Mon, 7 Jun 2021 at 17:39, Andy Shevchenko <andy.shevchenko@...il.com> wrote: > > On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma <bhupesh.sharma@...aro.org> wrote: > > > > SA8155p-adp board has two new regulator types - pmm8155au_1 and > > pmm8155au_2. > > > > The output power management circuits in these regulators include: > > - FTS510 smps, > > - HFS510 smps, and > > - LDO510 linear regulators > > ... > > > Cc: Linus Walleij <linus.walleij@...aro.org> > > Cc: Liam Girdwood <lgirdwood@...il.com> > > Cc: Mark Brown <broonie@...nel.org> > > Cc: Bjorn Andersson <bjorn.andersson@...aro.org> > > Cc: Vinod Koul <vkoul@...nel.org> > > Cc: Rob Herring <robh+dt@...nel.org> > > Cc: Andy Gross <agross@...nel.org> > > Cc: devicetree@...r.kernel.org > > Cc: linux-kernel@...r.kernel.org > > Cc: linux-gpio@...r.kernel.org > > Cc: bhupesh.linux@...il.com > > Use --cc or similar option when run `git send-email`, no need to > pollute the commit message with these. It's just a matter of preference IMO. I prefer to use a Cc list here. > > +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { > > > > + {}, > > Comma is not needed in the terminator line. Hmm.. it's similar to the syntax already used at several places in this file. See ' struct rpmh_vreg_init_data pm8150l_vreg_data[] ' for example. Unless there is an obvious issue with it, let's use the same to keep things similar from a syntax p-o-v. Thanks, Bhupesh > > > +}; > > -- > With Best Regards, > Andy Shevchenko
Powered by blists - more mailing lists