linux-kernel - Re: [PATCH v6 08/14] memory: tegra: Enable compile testing for all drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YL4rBYkWHpeit66m@orome.fritz.box>
Date:   Mon, 7 Jun 2021 16:19:49 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Nikola Milosavljević <mnidza@...look.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Peter Geis <pgwipeout@...il.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        Paul Fertser <fercerpav@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v6 08/14] memory: tegra: Enable compile testing for all
 drivers

On Mon, Jun 07, 2021 at 05:01:02PM +0300, Dmitry Osipenko wrote:
> 07.06.2021 16:36, Thierry Reding пишет:
> >> /bin/ld: warning: orphan section `__reservedmem_of_table' from `drivers/memory/tegra/tegra210-emc-table.o' being placed in section `__reservedmem_of_table'
> >> /bin/ld: drivers/memory/tegra/mc.o: in function `tegra_mc_probe':
> >> mc.c:(.text+0x87a): undefined reference to `reset_controller_register'
> >> make[1]: *** [/home/buildbot/worker/builddir/build/Makefile:1191: vmlinux] Error 1
> ...
> 
> > Not sure what to do about that orphaned __reservedmem_of_table section.
> > Maybe all we need to do is to select OF_RESERVED_MEM from
> > TEGRA210_EMC_TABLE?
> 
> Select won't work easily, but the dependency for TEGRA210_EMC should.

Select works if I also select OF_EARLY_FLATTREE. That's slightly odd
because typically that's something that the platform would select, but
there's precedent for doing this in drivers/clk/x86/Kconfig, so I think
it'd be fine.

The attached patch resolves both of the above issues for me.

Krzysztof: do you want to squash that into the problematic patch or do
you want me to send this as a follow-up patch for you to apply? I guess
the latter since you've already sent out the PR for Will and ARM SoC?

Thierry

--- >8 ---
diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
index f9bae36c03a3..ae8c57b921e6 100644
--- a/drivers/memory/tegra/Kconfig
+++ b/drivers/memory/tegra/Kconfig
@@ -4,6 +4,7 @@ config TEGRA_MC
 	default y
 	depends on ARCH_TEGRA || (COMPILE_TEST && COMMON_CLK)
 	select INTERCONNECT
+	select RESET_CONTROLLER
 	help
 	  This driver supports the Memory Controller (MC) hardware found on
 	  NVIDIA Tegra SoCs.
@@ -48,6 +49,8 @@ config TEGRA124_EMC
 config TEGRA210_EMC_TABLE
 	bool
 	depends on ARCH_TEGRA_210_SOC || COMPILE_TEST
+	select OF_EARLY_FLATTREE
+	select OF_RESERVED_MEM
 
 config TEGRA210_EMC
 	tristate "NVIDIA Tegra210 External Memory Controller driver"
--- >8 ---

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)