linux-kernel - Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56f088fe-8db2-54d4-bef3-72e5f893a414@aksignal.cz>
Date:   Mon, 7 Jun 2021 16:47:44 +0200
From:   Jiří Prchal <jiri.prchal@...ignal.cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Christian Eggers <ceggers@...i.de>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num



On 07. 06. 21 14:36, Greg Kroah-Hartman wrote:
> On Mon, Jun 07, 2021 at 02:26:39PM +0200, Jiri Prchal wrote:
>> +	return sysfs_emit(buf, "%016llx\n", *(unsigned long long *)at25->sernum);
> 
> That's a horrid hack, why not use the %*phN modifier?

Prints as little endian, is that OK?

Jiri