linux-kernel - RE: [PATCH][next] RDMA/irdma: remove redundant initialization of variable val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 14:53:58 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Colin King <colin.king@...onical.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][next] RDMA/irdma: remove redundant initialization of
 variable val

> Subject: [PATCH][next] RDMA/irdma: remove redundant initialization of variable val
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable val is being initialized with a value that is never read, it is being
> updated later on. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/infiniband/hw/irdma/ctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
> index 8bd3aecadaf6..b1023a7d0bd1 100644
> --- a/drivers/infiniband/hw/irdma/ctrl.c
> +++ b/drivers/infiniband/hw/irdma/ctrl.c
> @@ -3323,7 +3323,7 @@ __le64 *irdma_sc_cqp_get_next_send_wqe_idx(struct
> irdma_sc_cqp *cqp, u64 scratch
>   */
>  enum irdma_status_code irdma_sc_cqp_destroy(struct irdma_sc_cqp *cqp)  {
> -	u32 cnt = 0, val = 1;
> +	u32 cnt = 0, val;

Acked-by: Shiraz Saleem <shiraz.saleem@...el.com>