lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jun 2021 22:59:46 +0800 From: Tianyu Lan <ltykernel@...il.com> To: Christoph Hellwig <hch@....de> Cc: kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com, arnd@...db.de, dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org, akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com, rppt@...nel.org, hannes@...xchg.org, cai@....pw, krish.sadhukhan@...cle.com, saravanand@...com, Tianyu.Lan@...rosoft.com, konrad.wilk@...cle.com, m.szyprowski@...sung.com, robin.murphy@....com, boris.ostrovsky@...cle.com, jgross@...e.com, sstabellini@...nel.org, joro@...tes.org, will@...nel.org, xen-devel@...ts.xenproject.org, davem@...emloft.net, kuba@...nel.org, jejb@...ux.ibm.com, martin.petersen@...cle.com, iommu@...ts.linux-foundation.org, linux-arch@...r.kernel.org, linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, netdev@...r.kernel.org, vkuznets@...hat.com, thomas.lendacky@....com, brijesh.singh@....com, sunilmut@...rosoft.com Subject: Re: [RFC PATCH V3 11/11] HV/Storvsc: Add Isolation VM support for storvsc driver On 6/7/2021 2:46 PM, Christoph Hellwig wrote: > On Sun, May 30, 2021 at 11:06:28AM -0400, Tianyu Lan wrote: >> + for (i = 0; i < request->hvpg_count; i++) >> + dma_unmap_page(&device->device, >> + request->dma_range[i].dma, >> + request->dma_range[i].mapping_size, >> + request->vstor_packet.vm_srb.data_in >> + == READ_TYPE ? >> + DMA_FROM_DEVICE : DMA_TO_DEVICE); >> + kfree(request->dma_range); > > Unreadably long lines. You probably want to factor the quoted code into > a little readable helper and do the same for the map side. Good suggestion. Will update. Thanks.
Powered by blists - more mailing lists