linux-kernel - Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YL2lMWusp3ISYHJu@kroah.com>
Date:   Mon, 7 Jun 2021 06:48:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ricky WU <ricky_wu@...ltek.com>
Cc:     "arnd@...db.de" <arnd@...db.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "rui_feng@...lsil.com.cn" <rui_feng@...lsil.com.cn>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "vaibhavgupta40@...il.com" <vaibhavgupta40@...il.com>,
        "yang.lee@...ux.alibaba.com" <yang.lee@...ux.alibaba.com>,
        "keitasuzuki.park@...ab.ics.keio.ac.jp" 
        <keitasuzuki.park@...ab.ics.keio.ac.jp>,
        "chris.chiu@...onical.com" <chris.chiu@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG

On Mon, Jun 07, 2021 at 02:34:36AM +0000, Ricky WU wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Friday, June 4, 2021 10:48 PM
> > To: Ricky WU
> > Cc: arnd@...db.de; bhelgaas@...gle.com; rui_feng@...lsil.com.cn;
> > ulf.hansson@...aro.org; vaibhavgupta40@...il.com;
> > yang.lee@...ux.alibaba.com; keitasuzuki.park@...ab.ics.keio.ac.jp;
> > chris.chiu@...onical.com; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and
> > MODE_CFG
> > 
> > On Fri, Jun 04, 2021 at 10:42:11PM +0800, ricky_wu@...ltek.com wrote:
> > > From: Ricky Wu <ricky_wu@...ltek.com>
> > >
> > > Divide Realtek Card Reader Group into two different modes
> > > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250 Change back to use
> > > original way to control aspm
> > 
> > What is "aspm"?
> > 
> Active State Power Management (ASPM)

Great, please spell it out in the changelog text when you resubmit this.

> rtsx_comm_set_aspm: ASPM control function for our driver
> to make sure not enter power saving in process of init and card_detcct

Ok, can you please say all of this in the changelog text?

> > > +#define ASPM_MODE_CFG		0x01
> > > +#define ASPM_MODE_REG		0x02
> > > +	u8				aspm_mode;
> > 
> > Why not use an enum?
> > 
> 
> It is ok, we can have a V2 to use enum

Please do so.

thanks,

greg k-h