linux-kernel - Re: [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YL47Ny7hXZmgH/dx@smile.fi.intel.com>
Date:   Mon, 7 Jun 2021 18:28:55 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when
 accessing msg->header

On Thu, May 20, 2021 at 12:26:25PM +0300, Heikki Krogerus wrote:
> On Wed, May 19, 2021 at 11:55:34AM +0300, Andy Shevchenko wrote:
> > As LKP noticed the Sparse is not happy about strict type handling:
> >    .../typec/tcpm/wcove.c:380:50: sparse:     expected unsigned short [usertype] header
> >    .../typec/tcpm/wcove.c:380:50: sparse:     got restricted __le16 const [usertype] header
> > 
> > Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt()
> > in the affected code.
> > 
> > Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Thanks!

Greg, should I amend or resend this?

-- 
With Best Regards,
Andy Shevchenko