linux-kernel - Re: [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6cbc5eb-212c-0701-3e25-93bd8486ee30@gmail.com>
Date:   Tue, 8 Jun 2021 08:44:22 -0700
From:   James Smart <jsmart2021@...il.com>
To:     Zou Wei <zou_wei@...wei.com>, james.smart@...adcom.com,
        dick.kennedy@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Use list_move_tail instead of
 list_del/list_add_tail

On 6/7/2021 5:51 PM, Zou Wei wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   drivers/scsi/lpfc/lpfc_sli.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index e2cfb86..84a9101 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -20162,8 +20162,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
>   			(mb->u.mb.mbxCommand != MBX_REG_VPI))
>   			continue;
>   
> -		list_del(&mb->list);
> -		list_add_tail(&mb->list, &mbox_cmd_list);
> +		list_move_tail(&mb->list, &mbox_cmd_list);
>   	}
>   	/* Clean up active mailbox command with the vport */
>   	mb = phba->sli.mbox_active;
> 

Thanks

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james