linux-kernel - Re: [PATCH RESEND] arm64: meson: select COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1jczsw1fnj.fsf@starbuckisacylon.baylibre.com>
Date:   Tue, 08 Jun 2021 18:32:00 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kevin Hilman <khilman@...libre.com>
Subject: Re: [PATCH RESEND] arm64: meson: select COMMON_CLK


On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> Hi Jerome,
>
> On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@...libre.com> wrote:
>> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote:
>> > This fix the recent removal of clock drivers selection.
>> > While it is not necessary to select the clock drivers themselves, we need
>> > to select a proper implementation of the clock API, which for the meson, is
>> > CCF
>>
>> Applied, thanks!
>>
>> [1/1] arm64: meson: select COMMON_CLK
>>       commit: aea7a80ad5effd48f44a7a08c3903168be038a43
>>
>> Best regards,
>> --
>> Kevin Hilman <khilman@...libre.com>
>
> Why is this needed, and why would this make any difference?
> COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in
> arch/arm64/Kconfig selects it.

Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had
problem with COMMON_CLK (or any other clock implementation) being
selected. TBH, I don't remember it exactly ...

For sure this was a mistake.
Neil, can you still drop it and do you need a revert ?

>
> Gr{oetje,eeting}s,
>
>                         Geert