linux-kernel - Re: [PATCH] net: appletalk: fix some mistakes in grammar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <150d317762ebcbe7cb824ba6850bf6dc25ee1c00.camel@perches.com>
Date:   Mon, 07 Jun 2021 19:32:40 -0700
From:   Joe Perches <joe@...ches.com>
To:     13145886936@....com, davem@...emloft.net, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] net: appletalk: fix some mistakes in grammar

On Mon, 2021-06-07 at 19:25 -0700, 13145886936@....com wrote:
> From: gushengxian <gushengxian@...ong.com>
> 
> Fix some mistakes in grammar.
[]
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
>  
> 
>  		/*
>  		 * Phase 1 is fine on LocalTalk but we don't do
> -		 * EtherTalk phase 1. Anyone wanting to add it go ahead.
> +		 * EtherTalk phase 1. Anyone wanting to add it goes ahead.

This is really not better grammar.
It's describing how anyone should feel free to create an implementation.

It's also really old code that no one will use much anymore, so any
change to this module isn't particularly useful.