linux-kernel - Re: [PATCH] net: appletalk: fix some mistakes in grammar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 19:31:41 -0700
From:   Seth David Schoen <schoen@...alty.org>
To:     13145886936@....com
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] net: appletalk: fix some mistakes in grammar

13145886936@....com writes:

>   * Ergo, before the AppleTalk module can be removed, all AppleTalk
> - * sockets be closed from user space.
> + * sockets should be closed from user space.
>   */

This is a good correction, but in the other case

>  		/*
>  		 * Phase 1 is fine on LocalTalk but we don't do
> -		 * EtherTalk phase 1. Anyone wanting to add it go ahead.
> +		 * EtherTalk phase 1. Anyone wanting to add it goes ahead.

"go ahead" is meant as an imperative (like "If you want to add EtherTalk
phase 1 support, please go ahead [and do so]"), not an indicative (like
"If you want to add EtherTalk phase 1 support, you are adding it").  It
is an invitation addressed to future developers.

Addressing unspecified people directly in the second person with "anyone"
is a little unusual, but is grammatically acceptable (more usually with a
comma).  Anyone reading this, you now understand this point.