linux-kernel - Re: [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5f29e1c-f4ec-7a08-a97c-8a516ba6649a@gmail.com>
Date:   Tue, 8 Jun 2021 20:39:23 +0200
From:   Johan Jonker <jbx6244@...il.com>
To:     Jon Lin <jon.lin@...k-chips.com>, linux-spi@...r.kernel.org
Cc:     broonie@...nel.org, robh+dt@...nel.org, heiko@...ech.de,
        hjc@...k-chips.com, yifeng.zhao@...k-chips.com,
        sugar.zhang@...k-chips.com, linux-rockchip@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, p.yadav@...com,
        macroalpha82@...il.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Chris Morgan <macromorgan@...mail.com>
Subject: Re: [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036



On 6/8/21 4:33 AM, Jon Lin wrote:
> From: Chris Morgan <macromorgan@...mail.com>
> 
> Add a devicetree entry for the Rockchip SFC for the RK3036 SOC.
> 
> Signed-off-by: Chris Morgan <macromorgan@...mail.com>
> Signed-off-by: Jon Lin <jon.lin@...k-chips.com>
> ---
> 
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
> 
>  arch/arm/boot/dts/rk3036.dtsi | 42 +++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index e24230d50a78..e7faf815ca74 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -206,6 +206,17 @@
>  		status = "disabled";
>  	};
>  
> +	sfc: spi@...08000 {
> +		compatible = "rockchip,rk3036-sfc";
> +		reg = <0x10208000 0x4000>;
> +		interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru HCLK_SFC>, <&cru SCLK_SFC>;
> +		clock-names = "hclk_sfc", "clk_sfc";
> +		pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus4>;
> +		pinctrl-names = "default";
> +		status = "disabled";
> +	};
> +
>  	sdmmc: mmc@...14000 {
>  		compatible = "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc";
>  		reg = <0x10214000 0x4000>;
> @@ -684,6 +695,37 @@
>  			};
>  		};
>  

> +		serial_flash {

sfc {

Nodes are sort alphabetically.
Sort other patches with sfc nodes in this serie as well.
Maybe rename nodename consistent with sfc label?
Similar to nfc nodes?

> +			sfc_bus4: sfc-bus4 {
> +				rockchip,pins =

> +					<1 RK_PD0 3 &pcfg_pull_none>,
> +					<1 RK_PD1 3 &pcfg_pull_none>,
> +					<1 RK_PD2 3 &pcfg_pull_none>,
> +					<1 RK_PD3 3 &pcfg_pull_none>;

Keep align with the rest in the pinctrl node.
Check that in other sfc patches as well.

> +			};
> +
> +			sfc_bus2: sfc-bus2 {
> +				rockchip,pins =

> +					<1 RK_PD0 3 &pcfg_pull_none>,
> +					<1 RK_PD1 3 &pcfg_pull_none>;

dito

> +			};
> +
> +			sfc_cs0: sfc-cs0 {
> +				rockchip,pins =

> +					<2 RK_PA2 3 &pcfg_pull_none>;

dito

> +			};
> +
> +			sfc_cs1: sfc-cs1 {
> +				rockchip,pins =

> +					<2 RK_PA3 3 &pcfg_pull_none>;

dito

> +			};
> +
> +			sfc_clk: sfc-clk {
> +				rockchip,pins =

> +					<2 RK_PA4 3 &pcfg_pull_none>;

dito

> +			};
> +		};
> +
>  		emac {
>  			emac_xfer: emac-xfer {
>  				rockchip,pins = <2 RK_PB2 1 &pcfg_pull_default>, /* crs_dvalid */
>