linux-kernel - Re: [PATCH v4] ping: Check return value of function 'ping_queue_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210608.163006.1251722799035175174.davem@davemloft.net>
Date:   Tue, 08 Jun 2021 16:30:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengyongjun3@...wei.com
Cc:     yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ping: Check return value of function
 'ping_queue_rcv_skb'

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Tue, 8 Jun 2021 14:42:46 +0800

> --- a/net/ipv4/ping.c
> +++ b/net/ipv4/ping.c
> @@ -954,6 +954,7 @@ bool ping_rcv(struct sk_buff *skb)
>  	struct sock *sk;
>  	struct net *net = dev_net(skb->dev);
>  	struct icmphdr *icmph = icmp_hdr(skb);
> +	bool rc = false;
>  
>  	/* We assume the packet has already been checked by icmp_rcv */
>  
> @@ -968,14 +969,13 @@ bool ping_rcv(struct sk_buff *skb)
>  		struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
>  
>  		pr_debug("rcv on socket %p\n", sk);
> -		if (skb2)
> -			ping_queue_rcv_skb(sk, skb2);
> +		if (skb2 && !ping_queue_rcv_skb(sk, skb2))
> +			rc = true;
>  		sock_put(sk);
> -		return true;
>  	}
>  	pr_debug("no socket, dropping\n");
>  
> -	return false;
> +	return rc;

YOu have chsanged the control flowe in a way that this pr_debug() can be inaccurate.
It can print when we did find a socket.

Please fix this.

Thank you.