[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5ac9821151fc80e7cdcf0c524e73851e61eaafe2.camel@fi.rohmeurope.com>
Date: Tue, 8 Jun 2021 07:52:38 +0000
From: "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To: "axel.lin@...ics.com" <axel.lin@...ics.com>,
"broonie@...nel.org" <broonie@...nel.org>
CC: "lgirdwood@...il.com" <lgirdwood@...il.com>,
linux-power <linux-power@...rohmeurope.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: bd71815: Get rid of struct bd71815_pmic
On Mon, 2021-06-07 at 22:30 +0800, Axel Lin wrote:
> The content of bd71815_regulators is never changed, no need to
> duplicate
> it, thus remove descs[BD71815_REGULATOR_CNT].
> The *regmap, *dev and *rdev[BD71815_REGULATOR_CNT] are not really
> needed.
> The *gps is unused.
>
> Thus the struct bd71815_pmic can be removed.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> drivers/regulator/bd71815-regulator.c | 57 +++++++++--------------
> ----
> 1 file changed, 19 insertions(+), 38 deletions(-)
Thanks a lot Axel. This is nice!
We might need to decide the ops for LDO3 based on a DT configuration
because the LDO3 state can be tied to DCIN connection. Currently the
driver does not support that though - and this patch is a nice
simplification!
Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Best Regards
--Matti
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists