[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210608084913.1046606-1-chenxiaosong2@huawei.com>
Date: Tue, 8 Jun 2021 16:49:13 +0800
From: ChenXiaoSong <chenxiaosong2@...wei.com>
To: <jonnyc@...zon.com>, <lorenzo.pieralisi@....com>,
<bhelgaas@...gle.com>
CC: <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<yukuai3@...wei.com>, <yi.zhang@...wei.com>,
<chenxiaosong2@...wei.com>
Subject: [PATCH -next,resend] PCI: al: Remove redundant dev_err call in al_pcie_probe()
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@...wei.com>
---
drivers/pci/controller/dwc/pcie-al.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/dwc/pcie-al.c
index e8afa50129a8..fb4d1eed07ce 100644
--- a/drivers/pci/controller/dwc/pcie-al.c
+++ b/drivers/pci/controller/dwc/pcie-al.c
@@ -346,11 +346,8 @@ static int al_pcie_probe(struct platform_device *pdev)
controller_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"controller");
al_pcie->controller_base = devm_ioremap_resource(dev, controller_res);
- if (IS_ERR(al_pcie->controller_base)) {
- dev_err(dev, "couldn't remap controller base %pR\n",
- controller_res);
+ if (IS_ERR(al_pcie->controller_base))
return PTR_ERR(al_pcie->controller_base);
- }
dev_dbg(dev, "From DT: controller_base: %pR\n", controller_res);
--
2.25.4
Powered by blists - more mailing lists