linux-kernel - Re: [PATCH -next,resend] EDAC/armada_xp: Remove redundant dev_err call in axp_mc_probe() and aurora_l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Jun 2021 11:53:38 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     ChenXiaoSong <chenxiaosong2@...wei.com>
Cc:     jlu@...gutronix.de, mchehab@...nel.org, tony.luck@...el.com,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH -next,resend] EDAC/armada_xp: Remove redundant dev_err
 call in axp_mc_probe() and aurora_l2_probe()

On Tue, Jun 08, 2021 at 04:47:15PM +0800, ChenXiaoSong wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: ChenXiaoSong <chenxiaosong2@...wei.com>
> ---
>  drivers/edac/armada_xp_edac.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c
> index e3e757513d1b..9661c72e6554 100644
> --- a/drivers/edac/armada_xp_edac.c
> +++ b/drivers/edac/armada_xp_edac.c
> @@ -297,10 +297,8 @@ static int axp_mc_probe(struct platform_device *pdev)
>  	}
>  
>  	base = devm_ioremap_resource(&pdev->dev, r);
> -	if (IS_ERR(base)) {
> -		dev_err(&pdev->dev, "Unable to map regs\n");
> +	if (IS_ERR(base))
>  		return PTR_ERR(base);
> -	}
>  
>  	config = readl(base + SDRAM_CONFIG_REG);
>  	if (!(config & SDRAM_CONFIG_ECC_MASK)) {
> @@ -525,10 +523,8 @@ static int aurora_l2_probe(struct platform_device *pdev)
>  	}
>  
>  	base = devm_ioremap_resource(&pdev->dev, r);
> -	if (IS_ERR(base)) {
> -		dev_err(&pdev->dev, "Unable to map regs\n");
> +	if (IS_ERR(base))
>  		return PTR_ERR(base);
> -	}
>  
>  	l2x0_aux_ctrl = readl(base + L2X0_AUX_CTRL);
>  	if (!(l2x0_aux_ctrl & AURORA_ACR_PARITY_EN))
> --

https://lkml.kernel.org/r/YLT7JOR3fND5Y3K2@zn.tnic

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette