linux-kernel - Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e32ad2d9-f2b3-f5de-54e5-fe43cd5403a9@aksignal.cz>
Date:   Tue, 8 Jun 2021 12:07:52 +0200
From:   Jiří Prchal <jiri.prchal@...ignal.cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Christian Eggers <ceggers@...i.de>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num



On 08. 06. 21 11:53, Greg Kroah-Hartman wrote:
>>>> Prints as little endian, is that OK?
>>>
>>> You tell me!  What tool is going to be reading this?  What do they
>>> expect it to look like?
>>
>> sh, php in my usecase as unique id.
> 
> I am sorry, I do not understand.

In my use case: shell and php.

> 
>> So endianess does not matter to me too much. The question is what is usual
>> (like mac address, uuid...?).
> 
> What does the device export?  Why not just export it as:
> 	0123456789ABCDEF
> if it is 8 bytes long?

Yes, device contains 0123456789ABCDEF.

> 
>>> And it's a byte array, why would there be endian issues?
>>
>> Now is printed as one big number. Not real issue. Just human readability?
>> Should I turn back it to space separated bytes?
> 
> It's up to you, what do you want to do with it and what does a tool want
> it to look like?

Right now I export it as bytes separated by space. But no problem to 
change it.
Just asking: for generic users what would be better or is there "best 
practice"?

> 
> thanks,
> 
> greg k-h
>