linux-kernel - Re: [PATCH] recordmcount: Correct st

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFn7u5Mo2L-OxfTyNsfN0_Wkaa0U3Riw5PmfyCBYY_uNg@mail.gmail.com>
Date:   Tue, 8 Jun 2021 12:37:05 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mark-PK Tsai <mark-pk.tsai@...iatek.com>
Subject: Re: [PATCH] recordmcount: Correct st_shndx handling

On Tue, 8 Jun 2021 at 12:34, Peter Zijlstra <peterz@...radead.org> wrote:
>
>
> One should only use st_shndx when >SHN_UNDEF and <SHN_LORESERVE. When
> SHN_XINDEX, then use .symtab_shndx. Otherwise use 0.
>
> This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX.
>
> Reported-by: Mark-PK Tsai <mark-pk.tsai@...iatek.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Tested-by: Mark-PK Tsai <mark-pk.tsai@...iatek.com>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  scripts/recordmcount.h |   13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> --- a/scripts/recordmcount.h
> +++ b/scripts/recordmcount.h
> @@ -194,13 +194,18 @@ static unsigned int get_symindex(Elf_Sym
>         unsigned long offset;
>         int index;
>
> -       if (sym->st_shndx != SHN_XINDEX)
> +       if (sym->st_shndx > SHN_UNDEF &&
> +           sym->st_shndx < SHN_LORESERVE)
>                 return w2(sym->st_shndx);
>
> -       offset = (unsigned long)sym - (unsigned long)symtab;
> -       index = offset / sizeof(*sym);
> +       if (sym->st_shndx == SHN_XINDEX) {
> +               offset = (unsigned long)sym - (unsigned long)symtab;
> +               index = offset / sizeof(*sym);
>
> -       return w(symtab_shndx[index]);
> +               return w(symtab_shndx[index]);
> +       }
> +
> +       return 0;
>  }
>
>  static unsigned int get_shnum(Elf_Ehdr const *ehdr, Elf_Shdr const *shdr0)