linux-kernel - Re: [PATCH v4] ARM: dts: dra7: Fix duplicate USB4 target module node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c140f39c-9fe1-f7e1-3da5-fc5fff604714@ti.com>
Date:   Tue, 8 Jun 2021 13:40:34 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Gowtham Tammana <g-tammana@...com>, Suman Anna <s-anna@...com>,
        <tony@...mide.com>, <bcousson@...libre.com>
CC:     <robh+dt@...nel.org>, <linux-omap@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, Nisanth Menon <nm@...com>
Subject: Re: [PATCH v4] ARM: dts: dra7: Fix duplicate USB4 target module node



On 03/06/2021 01:04, Gowtham Tammana wrote:
> With [1] USB4 target-module node got defined in dra74x.dtsi file.
> However, the earlier definition in [2] was not removed, and this
> duplication of the target module is causing boot failure on dra74
> variant boards - dra7-evm, dra76-evm.
> 
> USB4 is only present in DRA74x variants, so keeping the entry in
> dra74x.dtsi and removing it from the top level interconnect hierarchy
> dra7-l4.dtsi file. This change makes the USB4 target module no longer
> visible to AM5718, DRA71x and DRA72x so removing references to it in
> their respective dts files.
> 
> [1]: commit c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for
> dra7 dwc3")
> [2]: commit 549fce068a311 ("ARM: dts: dra7: Add l4 interconnect
> hierarchy and ti-sysc data")
> 
> Fixes: c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3")
> Signed-off-by: Gowtham Tammana <g-tammana@...com>
> ---
> v4:
>    - moved the node under l4_per3 instead of ocp as per Tony and
>      Grygorii suggestion
> v3:
>    - https://lore.kernel.org/linux-arm-kernel/20210526213035.15448-1-g-tammana@ti.com/
>    - fixed error in references to the commits
>    - mentioned the boards that failed
> v2:
>    - https://lore.kernel.org/linux-arm-kernel/20210526172038.17542-1-g-tammana@ti.com/
>    - changed reference to commit sha instead of line numbers
>    - added Fixes: tag
>    - moved the defintion to dra74.dtsi as per Suman and Tony review comments
> v1:
>    - https://lore.kernel.org/linux-arm-kernel/20210521211851.14674-1-g-tammana@ti.com/
> 
> 
>   arch/arm/boot/dts/am5718.dtsi  |  6 +--
>   arch/arm/boot/dts/dra7-l4.dtsi | 22 --------
>   arch/arm/boot/dts/dra71x.dtsi  |  4 --
>   arch/arm/boot/dts/dra72x.dtsi  |  4 --
>   arch/arm/boot/dts/dra74x.dtsi  | 92 ++++++++++++++++++----------------
>   5 files changed, 50 insertions(+), 78 deletions(-)
> 

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
grygorii