linux-kernel - Re: [PATCH v2] reiserfs: add check for invalid 1st journal block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210608115645.GF5562@quack2.suse.cz>
Date:   Tue, 8 Jun 2021 13:56:45 +0200
From:   Jan Kara <jack@...e.cz>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Jan Kara <jack@...e.cz>, tiantao6@...ilicon.com,
        rdunlap@...radead.org, reiserfs-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+0ba9909df31c6a36974d@...kaller.appspotmail.com
Subject: Re: [PATCH v2] reiserfs: add check for invalid 1st journal block

On Tue 08-06-21 13:44:43, Pavel Skripkin wrote:
> On Mon, 17 May 2021 15:08:18 +0200
> Jan Kara <jack@...e.cz> wrote:
> 
> > On Mon 17-05-21 15:15:45, Pavel Skripkin wrote:
> > > syzbot reported divide error in reiserfs.
> > > The problem was in incorrect journal 1st block.
> > > 
> > > Syzbot's reproducer manualy generated wrong superblock
> > > with incorrect 1st block. In journal_init() wasn't
> > > any checks about this particular case.
> > > 
> > > For example, if 1st journal block is before superblock
> > > 1st block, it can cause zeroing important superblock members
> > > in do_journal_end().
> > > 
> > > Reported-by: syzbot+0ba9909df31c6a36974d@...kaller.appspotmail.com
> > > Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> > 
> > Thanks! I've added the patch to my tree.
> > 
> > 								Honza
> > 
> 
> Hi, Jan!
> 
> Is this patched got lost somehow? I did't find it in your tree here
> https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/.
> 
> Sorry to bother you, maybe Im missing something :)

It's sitting in my for_next branch as commit a149127be52f. I'll push it to
Linus in the coming merge window.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR