linux-kernel - Re: [PATCH -next] perf tools: Use list_move instead of list_del/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YL9mWZfQoc8AP49D@kernel.org>
Date:   Tue, 8 Jun 2021 09:45:13 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] perf tools: Use list_move instead of
 list_del/list_add

Em Tue, Jun 08, 2021 at 08:52:46AM +0800, Zou Wei escreveu:
> Using list_move() instead of list_del() + list_add().

Thanks, applied.

- Arnaldo

 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  tools/perf/util/srccode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/srccode.c b/tools/perf/util/srccode.c
> index c29edaa..476e998 100644
> --- a/tools/perf/util/srccode.c
> +++ b/tools/perf/util/srccode.c
> @@ -97,8 +97,7 @@ static struct srcfile *find_srcfile(char *fn)
>  	hlist_for_each_entry (h, &srcfile_htab[hval], hash_nd) {
>  		if (!strcmp(fn, h->fn)) {
>  			/* Move to front */
> -			list_del(&h->nd);
> -			list_add(&h->nd, &srcfile_list);
> +			list_move(&h->nd, &srcfile_list);
>  			return h;
>  		}
>  	}
> -- 
> 2.6.2
> 

-- 

- Arnaldo