linux-kernel - RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR02MB6523048911423F5583772FE9C7379@CH2PR02MB6523.namprd02.prod.outlook.com>
Date:   Tue, 8 Jun 2021 13:16:56 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     Baokun Li <libaokun1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Michal Simek <michals@...inx.com>,
        Shravya Kumbham <shravyak@...inx.com>,
        Matthew Murrian <matthew.murrian@...tsi.com>,
        Romain Perier <romain.perier@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Allen Pais <allen.lkml@...il.com>
CC:     "weiyongjun1@...wei.com" <weiyongjun1@...wei.com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "yangjihong1@...wei.com" <yangjihong1@...wei.com>,
        "yukuai3@...wei.com" <yukuai3@...wei.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead
 of list_del/list_add_tail

> -----Original Message-----
> From: Baokun Li <libaokun1@...wei.com>
> Sent: Tuesday, June 8, 2021 8:39 AM
> To: linux-kernel@...r.kernel.org; Vinod Koul <vkoul@...nel.org>; Michal
> Simek <michals@...inx.com>; Radhey Shyam Pandey <radheys@...inx.com>;
> Shravya Kumbham <shravyak@...inx.com>; Matthew Murrian
> <matthew.murrian@...tsi.com>; Romain Perier
> <romain.perier@...il.com>; Lars-Peter Clausen <lars@...afoo.de>;
> Krzysztof Kozlowski <krzk@...nel.org>; Allen Pais <allen.lkml@...il.com>
> Cc: weiyongjun1@...wei.com; yuehaibing@...wei.com;
> yangjihong1@...wei.com; yukuai3@...wei.com; libaokun1@...wei.com;
> dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; kernel-
> janitors@...r.kernel.org; Hulk Robot <hulkci@...wei.com>
> Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of
> list_del/list_add_tail
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
Thanks!
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 75c0b8e904e5..77022ef05ac5 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
> 
>  	chan->desc_submitcount++;
>  	chan->desc_pendingcount--;
> -	list_del(&desc->node);
> -	list_add_tail(&desc->node, &chan->active_list);
> +	list_move_tail(&desc->node, &chan->active_list);
>  	if (chan->desc_submitcount == chan->num_frms)
>  		chan->desc_submitcount = 0;
>