linux-kernel - Re: [PATCH] drm/mediatek: remove redundant error log print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAOTY_-QpO1d6+jnQsun8htG8sGqrVVA3Jy1kvLqOZC+CExxTQ@mail.gmail.com>
Date:   Tue, 8 Jun 2021 08:18:27 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Bernard Zhao <bernard@...o.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/mediatek: remove redundant error log print

Hi, Bernard:

Bernard Zhao <bernard@...o.com> 於 2021年6月3日 週四 下午7:15寫道：
>
> Fix coccicheck warning:
> drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is
> redundant because platform_get_irq() already prints an error.
>
> Signed-off-by: Bernard Zhao <bernard@...o.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index ae403c67cbd9..e2e4fc8b1360 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>
>         ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
>                                IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);

devm_request_irq() would have below call stack to allocate memory.
When allocate memory fail, it would not print any error message,
doesn't it?

devm_request_irq() -> devm_request_threaded_irq() -> devres_alloc() ->
devres_alloc_node() -> alloc_dr() -> kmalloc_node_track_caller()

Regards,
Chun-Kuang.

> -       if (ret) {
> -               dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
> +       if (ret)
>                 goto err_unregister_host;
> -       }
>
>         init_waitqueue_head(&dsi->irq_wait_queue);
>
> --
> 2.31.0
>