linux-kernel - Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YL95BgJTv/jyAYr1@lunn.ch>
Date:   Tue, 8 Jun 2021 16:04:54 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Zhou Yanjie <zhouyanjie@...yeetech.com>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com, paul@...pouillou.net
Subject: Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support.

On Tue, Jun 08, 2021 at 09:48:38PM +0800, Zhou Yanjie wrote:
> Hello Andrew,
> 
> On 2021/6/8 下午8:21, Andrew Lunn wrote:
> > Please wrap your text to around 75 characters per line.
> 
> 
> Sure.
> 
> 
> > 
> > I suspect you don't understand RGMII delays. As i said, normally, the
> > MAC does not add delays, the PHY does. Please take a closer look at
> > this.
> 
> 
> According to the description of ethernet-controller.yaml, "rgmii" seems
> 
> to allow MAC to add TX delay (the description in ethernet-controller.yaml
> 
> is "RX and TX delays are added by the MAC when required"), while rgmii-id
> 
> and rgmii-txid do not allow MAC to add delay (the description in
> 
> ethernet-controller.yaml is"RGMII with internal RX and TX delays provided
> 
> by the PHY, the MAC should not add the RX or TX delays in this case" and
> 
> "RGMII with internal TX delay provided by the PHY, the MAC should not add
> 
> an TX delay in this case"), I will add support for the other three RGMII
> modes
> 
> in the next version (I forgot to reply to this in the previous email).

Please follow the code all the way through. What gets passed to
phylink_create() is very important. If you have both the MAC and the
PHY adding delays, bad things will happen.

    Andrew