linux-kernel - Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Jun 2021 10:59:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs

On Tue, 8 Jun 2021 16:10:51 +0800
Zhen Lei <thunder.leizhen@...wei.com> wrote:

> 1) Run the following command to find and remove the leading spaces before
>    tabs:
>    find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
> 2) Manually check and correct if necessary
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Sorry, but I do not accept whitespace changes. Clean ups like this is
only welcomed if they come along with actual changes to the code around
them. Otherwise, this just causes extra churn and unwelcomed work for
the maintainer.

-- Steve


> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 833ade3d0b00..a555258556c5 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void)
>  		}
>  
>  		kthread_bind(rb_threads[cpu], cpu);
> - 		wake_up_process(rb_threads[cpu]);
> +		wake_up_process(rb_threads[cpu]);
>  	}
>  
>  	/* Now create the rb hammer! */