linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of ATF in SRAM and increase its max size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50bb1f20-ccca-fe94-eac1-70ac83bc004d@ti.com>
Date:   Wed, 9 Jun 2021 20:54:19 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     Aswath Govindraju <a-govindraju@...com>
CC:     Vignesh Raghavendra <vigneshr@...com>, Suman Anna <s-anna@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of
 ATF in SRAM and increase its max size



On 09/06/21 8:52 pm, Aswath Govindraju wrote:
> Hi Lokesh,
> 
> On 09/06/21 7:59 pm, Lokesh Vutla wrote:
>>
>>
>> On 07/06/21 7:08 pm, Aswath Govindraju wrote:
>>> Due to a limitation for USB DFU boot mode, SPL load address has to be less
>>> than  or equal to 0x70001000. So, load address of SPL and ATF have been
>>> moved to 0x70000000 and 0x701a0000 respectively.
>>>
>>> Also, the maximum size of ATF has been increased to 0x1c000 [1].
>>>
>>> Therefore, update ATF's location and maximum size accordingly in the device
>>> tree file.
>>>
>>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9
>>>
>>> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
>>> ---
>>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>>> index ca59d1f711f8..fcd12b6f10f6 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>>> @@ -13,8 +13,8 @@
>>>  		#size-cells = <1>;
>>>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>>>  
>>> -		atf-sram@0 {
>>> -			reg = <0x0 0x1a000>;
>>> +		atf-sram@...000 {
>>> +			reg = <0x1a0000 0x1c000>;
>>
>> After thinking a bot more, isn't size be 0x20000?
>> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO.
>>
> 
> The max size of ATF as defined above in [1] is 0x1c000 and as the
> argument has to reflect it I have modified it to the same.

ahh..Got it. Ignore my comment.

Thanks and regards,
Lokesh

> 
> Thanks,
> Aswath
> 
> 
>> Thanks and regards,
>> Lokesh
>>
>>>  		};
>>>  	};
>>>  
>>>
>