linux-kernel - RE: [PATCH v2 2/5] venus: Make sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1da15793122432e856b5f0b00f2cf6f@AcuMS.aculab.com>
Date:   Wed, 9 Jun 2021 16:03:03 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Stanimir Varbanov' <stanimir.varbanov@...aro.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Vikash Garodia <vgarodia@...eaurora.org>,
        Mansur Alisha Shaik <mansur@...eaurora.org>
Subject: RE: [PATCH v2 2/5] venus: Make sys_error flag an atomic bitops

From: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> Sent: 08 June 2021 12:42
> 
> Make the sys_error flag an atomic bitops in order to avoid
> locking in sys_error readers.

I don't think that makes any difference at all.

It is only atomic w.r.t other bitops in the same bitmap.
Even if it contained the fullest memory barrier you can
imagine the result of test_bit() is immediately stale.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)