linux-kernel - Re: [PATCH] platform/x86: dell-wmi-sysman: set fw_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <073c59e6-8d2c-2412-537b-2fd5f78538c8@redhat.com>
Date:   Wed, 9 Jun 2021 18:04:51 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     trix@...hat.com, divya.bharathi@...l.com, prasanth.ksr@...l.com,
        mgross@...ux.intel.com
Cc:     Dell.Client.Kernel@...l.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: set fw_attr_class
 storage-class to static

Hi Tom,

On 6/9/21 5:34 PM, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> An allyesconfig has this linking error
> drivers/platform/x86/think-lmi.o:
>   multiple definition of `fw_attr_class'
> drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:
>   first defined here
> 
> fw_attr_class is only used locally, so change to static
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Thank you for your 2 patches, I just merged another patch doing
the same earlier today.

Regards,

Hans


> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 1378c18786582..636bdfa83284d 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -25,7 +25,7 @@ struct wmi_sysman_priv wmi_priv = {
>  /* reset bios to defaults */
>  static const char * const reset_types[] = {"builtinsafe", "lastknowngood", "factory", "custom"};
>  static int reset_option = -1;
> -struct class *fw_attr_class;
> +static struct class *fw_attr_class;
>  
>  
>  /**
>