linux-kernel - Re: [PATCH v2] audit: Rename enum audit_state constants to avoid AUDIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhT1WGThacDZ=t_yz53yQGUzzXOoFLkBSEcyNzVuAzdp5Q@mail.gmail.com>
Date:   Tue, 8 Jun 2021 22:12:13 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Sergey Nazarov <s-nazarov@...dex.ru>
Cc:     Richard Guy Briggs <rgb@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH v2] audit: Rename enum audit_state constants to avoid
 AUDIT_DISABLED redefinition

On Tue, Jun 8, 2021 at 2:32 AM Sergey Nazarov <s-nazarov@...dex.ru> wrote:
>
> AUDIT_DISABLED defined in kernel/audit.h as element of enum audit_state
> and redefined in kernel/audit.c. This produces a warning when kernel builds
> with syscalls audit disabled and brokes kernel build if -Werror used.
> enum audit_state used in syscall audit code only. This patch changes
> enum audit_state constants prefix AUDIT to AUDIT_STATE to avoid
> AUDIT_DISABLED redefinition.
>
> v2: the comments of Richard Guy Briggs and Paul Moore were taken into account
>
> Signed-off-by: Sergey Nazarov <s-nazarov@...dex.ru>
> ---
>  kernel/audit.h   |  8 ++++----
>  kernel/auditsc.c | 34 +++++++++++++++++-----------------
>  2 files changed, 21 insertions(+), 21 deletions(-)

Merged into audit/next, thanks Sergey.

-- 
paul moore
www.paul-moore.com