linux-kernel - Re: [PATCH 3/3] bus: mhi: pci-generic: Fix hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210609174456.GA59730@thinkpad>
Date:   Wed, 9 Jun 2021 23:14:56 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     hemantk@...eaurora.org, bbhatt@...eaurora.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        jarvis.w.jiang@...il.com, loic.poulain@...aro.org,
        Shujun Wang <wsj20369@....com>
Subject: Re: [PATCH 3/3] bus: mhi: pci-generic: Fix hibernation

On Wed, Jun 09, 2021 at 07:04:35PM +0200, Greg KH wrote:
> On Sun, Jun 06, 2021 at 09:07:41PM +0530, Manivannan Sadhasivam wrote:
> > From: Loic Poulain <loic.poulain@...aro.org>
> > 
> > This patch fixes crash after resuming from hibernation. The issue
> > occurs when mhi stack is builtin and so part of the 'restore-kernel',
> > causing the device to be resumed from 'restored kernel' with a no
> > more valid context (memory mappings etc...) and leading to spurious
> > crashes.
> > 
> > This patch fixes the issue by implementing proper freeze/restore
> > callbacks.
> > 
> > Reported-by: Shujun Wang <wsj20369@....com>
> > Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > Link: https://lore.kernel.org/r/1622571445-4505-1-git-send-email-loic.poulain@linaro.org
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > ---
> >  drivers/bus/mhi/pci_generic.c | 36 ++++++++++++++++++++++++++++++++++-
> >  1 file changed, 35 insertions(+), 1 deletion(-)
> 
> Also needs a stable link, right?  I'll go add it by hand.  Please be
> more careful next time...
> 

Oops... yes, sorry.

Thanks,
Mani

> greg k-h