linux-kernel - Re: [PATCH -next] psi: Make symbol 'psi_cgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Jun 2021 12:56:01 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>, Tejun Heo <tj@...nel.org>
Cc:     Johannes Weiner <hannes@...xchg.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] psi: Make symbol 'psi_cgroups_enabled' static

On Wed, Jun 9, 2021 at 7:54 AM Wei Yongjun <weiyongjun1@...wei.com> wrote:
>
> The sparse tool complains as follows:
>
> kernel/sched/psi.c:151:1: warning:
>  symbol 'psi_cgroups_enabled' was not declared. Should it be static?
>
> This symbol is not used outside of psi.c, so marks it static.
>
> Fixes: 3958e2d0c34e ("cgroup: make per-cgroup pressure stall tracking configurable")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>

Thanks for reporting!

Tejun, how would to like this to be fixed? Will you take this patch as
is, roll it into my change which introduced this warning
(https://lore.kernel.org/patchwork/patch/1435705/) or would you prefer
me to resent the original patch with this fix?


> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index b773cae4c24b..d6e32de2f6af 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -148,7 +148,7 @@
>  static int psi_bug __read_mostly;
>
>  DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
>  #ifdef CONFIG_PSI_DEFAULT_DISABLED
>  static bool psi_enable;
>