[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210609220518.GA25895@raphael-debian-dev>
Date: Wed, 9 Jun 2021 22:48:30 +0000
From: Raphael Norwitz <raphael.norwitz@...anix.com>
To: Shanker R Donthineni <sdonthineni@...dia.com>
CC: Raphael Norwitz <raphael.norwitz@...anix.com>,
Amey Narkhede <ameynarkhede03@...il.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kw@...ux.com" <kw@...ux.com>, Sinan Kaya <okaya@...nel.org>,
Len Brown <lenb@...nel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v7 4/8] PCI/sysfs: Allow userspace to query and set device
reset mechanism
Yes - I got this one wrong.
Nevermind, looks good. Just the punctuation NIT.
On Wed, Jun 09, 2021 at 05:36:26PM -0500, Shanker R Donthineni wrote:
> Hi Raphael,
>
> On 6/9/21 4:57 PM, Raphael Norwitz wrote:
> >> +static ssize_t reset_method_show(struct device *dev,
> >> + struct device_attribute *attr,
> >> + char *buf)
> >> +{
> >> + struct pci_dev *pdev = to_pci_dev(dev);
> >> + ssize_t len = 0;
> >> + int i, prio;
> >> +
> >> + for (prio = PCI_RESET_METHODS_NUM; prio; prio--) {
> >> + for (i = 0; i < PCI_RESET_METHODS_NUM; i++) {
> >> + if (prio == pdev->reset_methods[i]) {
> >> + len += sysfs_emit_at(buf, len, "%s%s",
> >> + len ? "," : "",
> >> + pci_reset_fn_methods[i].name);
> >> + break;
> >> + }
> >> + }
> >> +
> >> + if (i == PCI_RESET_METHODS_NUM)
> >> + break;
> >> + }
> >> +
> > Don't you still need to ensure you add the newline even if there are no
> > reset methods set? If the len is zero why don't we need the newline?
> >
> > Otherwise looks good.
> >
>
> sysfs entry 'reset_method' will not be visible if there are no reset methods.
>
>
Powered by blists - more mailing lists