linux-kernel - Re: [PATCH] drm: qxl: ensure surf.data is ininitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210609070023.zp53qaopkbx2ol3a@sirius.home.kraxel.org>
Date:   Wed, 9 Jun 2021 09:00:23 +0200
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Dave Airlie <airlied@...hat.com>, Daniel Vetter <daniel@...ll.ch>,
        Alon Levy <alevy@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        spice-devel@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: qxl: ensure surf.data is ininitialized

On Tue, Jun 08, 2021 at 05:13:13PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The object surf is not fully initialized and the uninitialized
> field surf.data is being copied by the call to qxl_bo_create
> via the call to qxl_gem_object_create. Set surf.data to zero
> to ensure garbage data from the stack is not being copied.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Pushed to drm-misc-next.

thanks,
  Gerd