linux-kernel - Re: [PATCH -next] drm/hyperv: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Jun 2021 09:46:03 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Pu Lehui <pulehui@...wei.com>, drawat.floss@...il.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     zhangjinhao2@...wei.com, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/hyperv: Remove unused variable

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:
> Fixes gcc '-Wunused-const-variable' warning:
>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
>      'hyperv_modifiers' defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Pu Lehui <pulehui@...wei.com>
> ---
>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 02718e3e859e..3f83493909e6 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
>   	DRM_FORMAT_XRGB8888,
>   };
>   
> -static const uint64_t hyperv_modifiers[] = {
> -	DRM_FORMAT_MOD_LINEAR,
> -	DRM_FORMAT_MOD_INVALID
> -};

This constant should rather be used in the call to 
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161


> -
>   static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
>   {
>   	int ret;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)