linux-kernel - Re: [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYvU0aO5sEdDNH6C5FwO4yBMdCwY-0so5YTpBvyZqM58w@mail.gmail.com>
Date:   Wed, 9 Jun 2021 13:13:11 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Radim Pavlik <radim.pavlik@...-biometrics.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error
 in mcp23s08_irq()

On Tue, Jun 8, 2021 at 8:16 AM Zou Wei <zou_wei@...wei.com> wrote:

> Add the missing unlock before return from function mcp23s08_irq()
> in the error handling case.
>
> v1-->v2:
>    remove the "return IRQ_HANDLED" line
>
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Patch applied.

Yours,
Linus Walleij