[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210609112806.3565057-1-thierry.reding@gmail.com>
Date: Wed, 9 Jun 2021 13:28:04 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Philipp Zabel <p.zabel@...gutronix.de>
Cc: Dmitry Osipenko <digetx@...il.com>,
Jon Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH 0/2] memory: tegra: Fixes for COMPILE_TEST
From: Thierry Reding <treding@...dia.com>
After COMPILE_TEST was enabled for the Tegra MC driver, Krzysztof
reported that this can fail to build on x86 configurations because some
dependencies are not explicitly pulled in.
Fix this by adding missing dependencies for OF_RESERVED_MEM and by
providing compile-test stubs for reset controller registration API.
Note that I was initially trying to fix the reset controller problem by
selecting RESET_CONTROLLER. This works but is discouraged because it can
create circular dependencies. And sure enough, changing that "select" to
a "depends on" triggered a circular dependency because there are already
quite a few drivers that select RESET_CONTROLLER. I suppose that's fine
as long as everybody uses "select" rather than "depends on", but it is
not a very robust solution.
Dmitry and Krzysztof were both in favour of adding the reset controller
stubs, so that's what I went with.
Thierry
Thierry Reding (2):
memory: tegra: Add missing dependencies
reset: Add compile-test stubs
drivers/memory/tegra/Kconfig | 2 ++
include/linux/reset-controller.h | 22 ++++++++++++++++++++++
2 files changed, 24 insertions(+)
--
2.31.1
Powered by blists - more mailing lists