linux-kernel - Re: [PATCH 1/2] memory: tegra: Add missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c762772-929e-2eb8-6568-4aa82ea2f9ad@gmail.com>
Date:   Wed, 9 Jun 2021 14:58:00 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Jon Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] memory: tegra: Add missing dependencies

09.06.2021 14:28, Thierry Reding пишет:
> From: Thierry Reding <treding@...dia.com>
> 
> When enabling the COMPILE_TEST Kconfig option, the Tegra memory
> controller can be built without ARCH_TEGRA being selected. However, the
> driver implicitly depends on some symbols pulled in via ARCH_TEGRA,
> which causes the build to break.
> 
> Add explicit dependencies for OF_EARLY_FLATTREE and OF_RESERVED_MEM to
> the Tegra MC Kconfig option to make sure they are selected even if
> ARCH_TEGRA is not.
> 
> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  drivers/memory/tegra/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
> index f9bae36c03a3..ecfb071fc4f4 100644
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> @@ -48,6 +48,8 @@ config TEGRA124_EMC
>  config TEGRA210_EMC_TABLE
>  	bool
>  	depends on ARCH_TEGRA_210_SOC || COMPILE_TEST
> +	select OF_EARLY_FLATTREE
> +	select OF_RESERVED_MEM
>  
>  config TEGRA210_EMC
>  	tristate "NVIDIA Tegra210 External Memory Controller driver"
> 

Will this work if CONFIG_OF is disabled?