linux-kernel - Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfa3162b-32eb-487a-d01e-6d69293c9965@huawei.com>
Date:   Wed, 9 Jun 2021 20:13:35 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     <jaswinder.singh@...aro.org>, <eric@...olt.net>,
        <jassisinghbrar@...il.com>
CC:     <bcm-kernel-feedback-list@...adcom.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>, <yukuai3@...wei.com>
Subject: Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err
 call in flexrm_mbox_probe()

在 2021/6/1 16:28, Zhihao Cheng 写道:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
> ---
>   drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index b4f33dc399a0..78073ad1f2f1 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		goto fail;
>   	}
>   	regs_end = mbox->regs + resource_size(iomem);

friendly ping.