linux-kernel - Re: [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Jun 2021 14:11:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hbut_tan@....com
Cc:     elder@...nel.org, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, tanzhongjun@...ong.com
Subject: Re: [PATCH] soc: qcom: ipa: Remove superfluous error message
 around platform_get_irq()

From:  Zhongjun Tan <hbut_tan@....com>
Date: Thu, 10 Jun 2021 22:01:18 +0800

> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index 34b68dc43886..93270e50b6b3 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
>  	int ret;
>  
>  	ret = platform_get_irq_byname(smp2p->ipa->pdev, name);
> -	if (ret <= 0) {
> -		dev_err(dev, "DT error %d getting \"%s\" IRQ property\n",
> -			ret, name);
> +	if (ret <= 0)
Applied, but this code still rejects an irq of zero which is a valid irq number.