linux-kernel - Re: [f2fs-dev] [PATCH v2] f2fs: introduce f2fs_casefold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMKY11PC5y/EfZYf@gmail.com>
Date:   Thu, 10 Jun 2021 15:57:27 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     jaegeuk@...nel.org, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: introduce f2fs_casefold_name slab
 cache

On Tue, Jun 08, 2021 at 08:00:22AM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> Add a slab cache: "f2fs_casefold_name" for memory allocation
> of casefold name.

Commit message should say "f2fs_casefolded_name", not "f2fs_casefold_name".

> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
> v2:
> - change slab cache name to "f2fs_casefolded_name"
> - add a "f2fs_" prefix for slab cache variable name
>  fs/f2fs/dir.c      | 17 +++++++++++------
>  fs/f2fs/recovery.c |  6 +++++-
>  fs/f2fs/super.c    | 24 ++++++++++++++++++++++++

Otherwise this looks good.

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric