linux-kernel - Re: [PATCH -next] crypto: remove CRYPTOA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMKZnrwYQVF7ttYw@gmail.com>
Date:   Thu, 10 Jun 2021 16:00:46 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Liu Shixin <liushixin2@...wei.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] crypto: remove CRYPTOA_U32 and related functions

On Sat, Jun 05, 2021 at 01:39:02PM +0800, Liu Shixin wrote:
> According to the advice of Eric and Herbert, type CRYPTOA_U32
> has been unused for over a decade, so remove the code related to
> CRYPTOA_U32.
> 
> After removing CRYPTOA_U32, the type of the variable attrs can be
> changed from union to struct.
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> ---
>  crypto/algapi.c         | 18 ------------------
>  crypto/algboss.c        | 32 +++++++-------------------------
>  include/crypto/algapi.h |  1 -
>  include/linux/crypto.h  |  5 -----
>  4 files changed, 7 insertions(+), 49 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

One nit below:

> +		param->attrs[i].attr.rta_len =
> +			sizeof(param->attrs[i]);

These two lines can be joined into one.

- Eric