linux-kernel - Re: [PATCH 04/29] do_anonymous_page: use update_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpFJfry1Td8Sbv27pqxE2CdSyH=6Cy065vL69JNQex1kOw@mail.gmail.com>
Date:   Wed, 9 Jun 2021 17:38:28 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Michel Lespinasse <michel@...pinasse.org>
Cc:     Linux-MM <linux-mm@...ck.org>,
        Linux-Kernel <linux-kernel@...r.kernel.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Matthew Wilcox <willy@...radead.org>,
        Rik van Riel <riel@...riel.com>,
        Paul McKenney <paulmck@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Joel Fernandes <joelaf@...gle.com>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH 04/29] do_anonymous_page: use update_mmu_tlb()

On Fri, Apr 30, 2021 at 12:52 PM Michel Lespinasse
<michel@...pinasse.org> wrote:
>
> update_mmu_tlb() can be used instead of update_mmu_cache() when the
> page fault handler detects that it lost the race to another page fault.
>
> (TODO double check with Bibo Mao <maobibo@...ngson.cn>)

You probably can drop this TODO. It looks like this one call was
missed in https://patchwork.kernel.org/project/linux-mips/patch/1590375160-6997-2-git-send-email-maobibo@loongson.cn
after Andrew asked to replace all update_mmu_cache() calls with an
alias in the previous version of this patch here:
https://patchwork.kernel.org/project/linux-mips/patch/1590031837-9582-2-git-send-email-maobibo@loongson.cn/#23374625.

>
> Signed-off-by: Michel Lespinasse <michel@...pinasse.org>
> ---
>  mm/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 550405fc3b5e..59ff65cb3ab4 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3567,7 +3567,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>         vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address,
>                         &vmf->ptl);
>         if (!pte_none(*vmf->pte)) {
> -               update_mmu_cache(vma, vmf->address, vmf->pte);
> +               update_mmu_tlb(vma, vmf->address, vmf->pte);
>                 goto release;
>         }
>
> --
> 2.20.1
>