linux-kernel - Re: [PATCH] memory: tegra: Delete dead debugfs checking code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162330973162.9991.7770026774132794997.b4-ty@canonical.com>
Date:   Thu, 10 Jun 2021 09:22:16 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Joseph Lo <josephl@...dia.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-tegra@...r.kernel.org,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Nathan Chancellor <nathan@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Qinglang Miao <miaoqinglang@...wei.com>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] memory: tegra: Delete dead debugfs checking code

On Wed, 9 Jun 2021 12:55:25 +0300, Dan Carpenter wrote:
> The debugfs_create_dir() function does not return NULL, it returns error
> pointers.  But in normal situations like this where the caller is not
> dereferencing "emc->debugfs.root" then we are not supposed to check the
> return.  So instead of fixing these checks, we should delete them.

Applied, thanks!

[1/1] memory: tegra: Delete dead debugfs checking code
      commit: c7c65703260c88a3e4d7387b2d03023c3625c6d4

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>